studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

attribute system #5

Closed
zephyr wants to merge 0 commits from feature-attribute into main
pull from: feature-attribute
merge into: studio:main
Conversation 1 Commits - Files Changed 307 +14734 -562
zephyr commented 2023-07-23 15:19:13 -04:00
Owner
Copy Link

Updates #2.

Updates #2.
zephyr added 1 commit 2023-07-23 15:19:13 -04:00
add Attribute definition
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
541cdfeed3 
Updates #2.
zephyr requested review from madxmike 2023-07-23 15:19:25 -04:00
zephyr force-pushed feature-attribute from 541cdfeed3 to 08b2f22052 2023-07-23 15:38:00 -04:00 Compare
madxmike reviewed 2023-07-23 17:28:31 -04:00
Assets/Scripts/Attribute.cs
@ -0,0 +16,4 @@
/// Permanently increase the stat value.
/// </summary>
/// <param name="by">Increase amount.</param>
public void LevelUp(long by)
madxmike commented 2023-07-23 17:27:27 -04:00
Owner
Copy Link

As i think about this, what we actually probably want is this whole thing to be data driven from a table (effectively a sparse mapping of numbers).

So we can define a table like "Healing Done" that has level mulitpliers and level breaks

Level: 1 | 2 | 3 | 10
Heal: 100 | 200| 1000 | 10000

But as i think about it more, we might just want both. A simple long scalar that we can control with whatever, and another impl thats a table based thing.

As i think about this, what we actually probably want is this whole thing to be data driven from a table (effectively a sparse mapping of numbers). So we can define a table like "Healing Done" that has level mulitpliers and level breaks Level: 1 | 2 | 3 | 10 Heal: 100 | 200| 1000 | 10000 But as i think about it more, we might just want both. A simple long scalar that we can control with whatever, and another impl thats a table based thing.
madxmike commented 2023-07-23 18:10:24 -04:00
Owner
Copy Link

Lets just keep it simple for now and use this one. If we find we want a table driven one then we can make it.

Lets just keep it simple for now and use this one. If we find we want a table driven one then we can make it.
madxmike approved these changes 2023-07-23 18:10:27 -04:00
zephyr changed title from WIP: attribute system to attribute system 2023-07-23 18:12:41 -04:00
zephyr commented 2023-07-28 18:36:34 -04:00
Author
Owner
Copy Link

The current state of this PR was included in 4245513c7c.

The current state of this PR was included in 4245513c7c.
zephyr closed this pull request 2023-07-28 18:36:34 -04:00
zephyr deleted branch feature-attribute 2023-07-28 18:36:48 -04:00
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
madxmike
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/idle-survivors#5
No description provided.
Delete Branch "feature-attribute"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?