studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

feature-waves #16

Merged
madxmike merged 2 commits from feature-waves into main 2023-08-10 17:24:42 -04:00
Conversation 1 Commits 2 Files Changed 40 +944
madxmike commented 2023-08-09 21:50:03 -04:00
Owner
Copy Link

Implements basic waves of enemies that spawn. #11

Implements basic waves of enemies that spawn. #11
madxmike added 2 commits 2023-08-09 21:50:03 -04:00
Initial pass on wave spawning. 4182b3340d
Initial pass on wave spawning.
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
90fc5331bf
zephyr approved these changes 2023-08-09 22:12:47 -04:00
Assets/Scripts/Enemy.cs
@@ -0,0 +1,11 @@
using UnityEngine;
namespace DefaultNamespace
zephyr commented 2023-08-09 21:55:59 -04:00
Owner
Copy Link

who

who
madxmike commented 2023-08-09 22:15:09 -04:00
Author
Owner
Copy Link

Anything in the top level package gets put under DefaultNamespace. Rider puts this automatically when you make a new file in the top level package. Really we want to set the namespace for that package to IdleSurvivors or something.

Anything in the top level package gets put under DefaultNamespace. Rider puts this automatically when you make a new file in the top level package. Really we want to set the namespace for that package to IdleSurvivors or something.
Assets/Scripts/Wave/SpawnDistribution.cs
@@ -0,0 +4,4 @@
{
Uniform,
Random,
DiskRandom
zephyr commented 2023-08-09 22:00:08 -04:00
Owner
Copy Link

missing trailing comma

missing trailing comma
Assets/Scripts/Wave/WaveSpawner.cs
@@ -0,0 +12,4 @@
{
public class WaveSpawner : MonoBehaviour
{
[SerializeField] private SpawnWaveSOEventChannelSO startNewSpawnWaveEventChannel;
zephyr commented 2023-08-09 22:04:02 -04:00
Owner
Copy Link

nit: verbose name

nit: verbose name
👀 1 🎉 1 😆 1
Assets/Scripts/Wave/WaveSpawner.cs
@@ -0,0 +72,4 @@
var enemyPackSpawnPosition = spawnCenter.position + enemyPackSpawnOffset;
var enemyPackToSpawn = enemyPacksToSpawn[packN];
for (var enemyN = 0; enemyN < enemyPackToSpawn.Count; enemyN++)
zephyr commented 2023-08-09 22:08:10 -04:00
Owner
Copy Link

there's no foreach-ish loop appropriate to use here?

there's no foreach-ish loop appropriate to use here?
madxmike commented 2023-08-09 22:14:08 -04:00
Author
Owner
Copy Link

I need to keep track of the count of enemies that have spawned

I need to keep track of the count of enemies that have spawned
madxmike merged commit 7b48612c4b into main 2023-08-10 17:24:42 -04:00
madxmike deleted branch feature-waves 2023-08-10 17:24:42 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
zephyr
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
madxmike zephyr
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: studio/idle-survivors#16
No description provided.
Delete Branch "feature-waves"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?