studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

refactor: unify runtime sets, update naming of event channels #17

Merged
madxmike merged 1 commits from refactor-unify-naming into main 2023-08-12 23:26:36 -04:00
Conversation 0 Commits 1 Files Changed 21 +104 -80
madxmike commented 2023-08-10 18:16:56 -04:00
Owner
Copy Link

Some general refactors:
Turns HeroPartySO into a runtime set class.
Make runtime set an IEnumerable
Simplify name of events

Some general refactors: Turns HeroPartySO into a runtime set class. Make runtime set an IEnumerable Simplify name of events
madxmike added 1 commit 2023-08-10 18:16:57 -04:00
refactor: unify runtime sets, update naming of event channels
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
22995ac307
zephyr approved these changes 2023-08-10 21:18:56 -04:00
Assets/Scripts/HeroPartySO.cs
@ -4,4 +0,0 @@
using UnityEngine;
[CreateAssetMenu(fileName = "HeroParty", menuName = "Hero Party")]
public class HeroPartySO : ScriptableObject
zephyr commented 2023-08-10 21:18:53 -04:00
Owner
Copy Link

Just FYI, I made the hero party a separate class rather than a generic RuntimeSetSO because the hero party will have other constraints, e.g. on size.

Just FYI, I made the hero party a separate class rather than a generic RuntimeSetSO because the hero party will have other constraints, e.g. on size.
madxmike commented 2023-08-10 21:55:40 -04:00
Author
Owner
Copy Link

test

test
❤️ 1
zephyr commented 2023-08-11 21:53:32 -04:00
Owner
Copy Link

srtinky

srtinky
madxmike commented 2023-08-12 23:33:15 -04:00
Author
Owner
Copy Link

test

test
madxmike merged commit ad725ee518 into main 2023-08-12 23:26:36 -04:00
madxmike deleted branch refactor-unify-naming 2023-08-12 23:26:36 -04:00
madxmike reviewed 2023-08-12 23:26:43 -04:00
Assets/Scripts/Events/SpawnWaveEventSO.cs
@ -0,0 +4,4 @@
namespace Events
{
[CreateAssetMenu(menuName = "Events/Spawn Wave Event")]
madxmike commented 2023-08-10 22:24:20 -04:00
Author
Owner
Copy Link

test

test
Assets/Scripts/Events/SpawnWaveEventSO.cs
@ -0,0 +5,4 @@
namespace Events
{
[CreateAssetMenu(menuName = "Events/Spawn Wave Event")]
public class SpawnWaveEventSO : ScriptableObject
madxmike commented 2023-08-10 21:52:20 -04:00
Author
Owner
Copy Link

testtest

testtest
madxmike commented 2023-08-10 22:18:46 -04:00
Author
Owner
Copy Link

test

test
Sign in to join this conversation.
Reviewers
No reviewers
zephyr
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/idle-survivors#17
No description provided.
Delete Branch "refactor-unify-naming"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?