studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

feature-duder #9

Merged
zephyr merged 6 commits from feature-duder into main 2023-08-04 19:37:13 -04:00
Conversation 0 Commits 6 Files Changed 10 +245
zephyr commented 2023-07-30 21:17:54 -04:00
Owner
Copy Link

Updates #3.

Updates #3.
zephyr added 2 commits 2023-07-30 21:17:54 -04:00
add hero component
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
5920e63d0c
zephyr added 1 commit 2023-08-01 15:03:58 -04:00
add hero prefab
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
3cc3e74f01
zephyr changed title from WIP: feature-duder to feature-duder 2023-08-01 15:09:15 -04:00
zephyr added 1 commit 2023-08-01 15:43:04 -04:00
rename private serialized fields
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
830444211f
zephyr requested review from madxmike 2023-08-02 18:10:50 -04:00
madxmike reviewed 2023-08-02 19:13:51 -04:00
Assets/Scripts/Heroism.cs Outdated
@ -0,0 +6,4 @@
/// Component that makes a duder a duder.
/// Manages class, skills, level, attrs, and AI.
/// </summary>
public class Heroism : MonoBehaviour
madxmike commented 2023-08-02 19:12:14 -04:00
Owner
Copy Link

Could we name this like HeroUnit or something

HeroUnit

EnemyUnit

Could we name this like `HeroUnit` or something `HeroUnit` `EnemyUnit`
zephyr marked this conversation as resolved
Assets/Scripts/Heroism.cs Outdated
@ -0,0 +11,4 @@
[SerializeField] private new string name;
[SerializeField] private HeroClassSO class_;
[SerializeField] private long level;
[SerializeField] private long xp;
madxmike commented 2023-08-02 19:13:47 -04:00
Owner
Copy Link

dont change this now, but it would be nice in the future if we could encapsulate the concepts of level and xp in a single class. It might contain a XP -> level curve and then we can jsut .addXp and it will figure everything out. Would be useful if we have anywhere else that needs the same concepts

dont change this now, but it would be nice in the future if we could encapsulate the concepts of level and xp in a single class. It might contain a XP -> level curve and then we can jsut .addXp and it will figure everything out. Would be useful if we have anywhere else that needs the same concepts
zephyr marked this conversation as resolved
zephyr added 1 commit 2023-08-02 22:31:14 -04:00
rename Heroism -> HeroUnit
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
fc14ef1780
madxmike approved these changes 2023-08-04 11:16:43 -04:00
zephyr added 1 commit 2023-08-04 19:33:31 -04:00
Merge branch 'main' into feature-duder
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
9998bff138
zephyr merged commit 81c1c0de0e into main 2023-08-04 19:37:13 -04:00
zephyr deleted branch feature-duder 2023-08-04 19:37:13 -04:00
zephyr referenced this issue from a commit 2023-08-04 19:37:14 -04:00
feature-duder (#9)
madxmike referenced this issue from a commit 2023-08-09 21:40:56 -04:00
feature-duder (#9)
Sign in to join this conversation.
Reviewers
No reviewers
madxmike
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/idle-survivors#9
No description provided.
Delete Branch "feature-duder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?