studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

feature-attributes #7

Merged
zephyr merged 10 commits from feature-attributes into main 2023-07-30 11:58:19 -04:00
Conversation 0 Commits 10 Files Changed 13 +190 -34
zephyr commented 2023-07-30 02:40:08 -04:00
Owner
Copy Link
No description provided.
zephyr added 4 commits 2023-07-30 02:40:08 -04:00
rename HeroAttributes -> HeroAttributesSO
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
3b0fc4481e
zephyr added 1 commit 2023-07-30 09:33:23 -04:00
add enemy attributes
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
124cb74bd5
madxmike reviewed 2023-07-30 10:25:43 -04:00
Assets/Scripts/Attribute.cs Outdated
@ -3,3 +3,3 @@
using UnityEngine;
public struct Attribute
public class Attribute : ScriptableObject
madxmike commented 2023-07-30 10:23:54 -04:00
Owner
Copy Link

Missing SO suffix

Missing SO suffix
zephyr commented 2023-07-30 11:01:45 -04:00
Author
Owner
Copy Link

I think this should go back to a struct rather than an SO. But it also seems like that makes it so the editor can't see them. Might need to implement a custom editor?

I think this should go back to a struct rather than an SO. But it also seems like that makes it so the editor can't see them. Might need to implement a custom editor?
zephyr marked this conversation as resolved
Assets/Scripts/EffectSO.cs Outdated
@ -0,0 +6,4 @@
/// <summary>
/// Additive change applied before multiplicative scaling.
/// </summary>
public long Base { get; private set; }
madxmike commented 2023-07-30 10:24:53 -04:00
Owner
Copy Link

If we private set here is the editor able to set these values?

If we private set here is the editor able to set these values?
zephyr commented 2023-07-30 10:55:23 -04:00
Author
Owner
Copy Link

Tried some things. It looks like the editor can't set properties at all, only fields.

Tried some things. It looks like the editor can't set properties at all, only fields.
zephyr marked this conversation as resolved
zephyr added 5 commits 2023-07-30 11:18:32 -04:00
add example Effect and EnemyAttributes assets
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
d9bbef4b05
madxmike approved these changes 2023-07-30 11:44:43 -04:00
zephyr changed title from WIP: feature-attributes to feature-attributes 2023-07-30 11:45:51 -04:00
zephyr merged commit 51fabc12b6 into main 2023-07-30 11:58:19 -04:00
zephyr deleted branch feature-attributes 2023-07-30 11:58:19 -04:00
zephyr referenced this issue from a commit 2023-07-30 11:58:20 -04:00
feature-attributes (#7)
Sign in to join this conversation.
Reviewers
No reviewers
madxmike
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/idle-survivors#7
No description provided.
Delete Branch "feature-attributes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?