studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

party #15

Merged
zephyr merged 4 commits from party into main 2023-08-07 12:34:42 -04:00
Conversation 0 Commits 4 Files Changed 12 +266 -6
zephyr commented 2023-08-06 23:50:01 -04:00
Owner
Copy Link

Resolves #6.
Updates #3.

Resolves #6. Updates #3.
zephyr added 3 commits 2023-08-06 23:50:01 -04:00
test that heroes are tracked by the party
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
15d8d1837d
zephyr requested review from madxmike 2023-08-06 23:50:27 -04:00
madxmike reviewed 2023-08-07 08:35:02 -04:00
Assets/Scripts/HeroUnit.cs
@ -16,0 +20,4 @@
private void OnEnable()
{
// NOTE(zeph): Party is mandatory. If none is set, we want an exception.
madxmike commented 2023-08-07 08:34:06 -04:00
Owner
Copy Link

I think its clearer to make these types of notes into assertions. Assert.IsNotNull(party) or something like it.

I think its clearer to make these types of notes into assertions. `Assert.IsNotNull(party)` or something like it.
zephyr marked this conversation as resolved
Assets/Scripts/HeroUnit.cs
@ -16,0 +29,4 @@
party.Remove(this);
}
internal HeroPartySO getParty()
madxmike commented 2023-08-07 08:33:05 -04:00
Owner
Copy Link

Should use a property instead of a getter

Should use a property instead of a getter
zephyr marked this conversation as resolved
zephyr added 1 commit 2023-08-07 12:31:04 -04:00
use property rather than getter for hero party
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
bdc0fe543a
madxmike approved these changes 2023-08-07 12:33:40 -04:00
zephyr merged commit a67aee24aa into main 2023-08-07 12:34:42 -04:00
zephyr deleted branch party 2023-08-07 12:34:42 -04:00
zephyr referenced this issue from a commit 2023-08-07 12:34:43 -04:00
party (#15)
madxmike referenced this issue from a commit 2023-08-09 21:40:56 -04:00
party (#15)
Sign in to join this conversation.
Reviewers
No reviewers
madxmike
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/idle-survivors#15
No description provided.
Delete Branch "party"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?