zephyr/chord
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use path values instead of query parameters for lookup

Browse Source
This commit is contained in:
Branden J Brown 2025-03-13 21:07:10 -04:00
parent 8047f4f13e
commit 4b44ffcd13
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
chord/httpnode/client.go
View File

@ -27,8 +27,7 @@ func (cl *Client) Find(ctx context.Context, s chord.Peer, id chord.ID) (chord.Pe
url := url.URL{ url := url.URL{
Scheme: "http", Scheme: "http",
Host: addr.String(), Host: addr.String(),
Path: path.Join("/", cl.APIBase, "key"), Path: path.Join("/", cl.APIBase, "key", id.String()),
RawQuery: url.Values{"s": {id.String()}}.Encode(),
} }
req, err := http.NewRequestWithContext(ctx, "GET", url.String(), nil) req, err := http.NewRequestWithContext(ctx, "GET", url.String(), nil)
if err != nil { if err != nil {

4
chord/httpnode/server.go
View File

@ -45,7 +45,7 @@ func New(l net.Listener, cl chord.Client) (*Node, error) {
// Router creates a handler for the Chord HTTP endpoints. // Router creates a handler for the Chord HTTP endpoints.
func (n *Node) Router() http.Handler { func (n *Node) Router() http.Handler {
m := http.NewServeMux() m := http.NewServeMux()
m.HandleFunc("GET /key", n.key) m.HandleFunc("GET /key/{id}", n.key)
m.HandleFunc("POST /pred", n.notify) m.HandleFunc("POST /pred", n.notify)
m.HandleFunc("GET /neighbors", n.neighbors) m.HandleFunc("GET /neighbors", n.neighbors)
return m return m
@ -66,7 +66,7 @@ func (n *Node) Check(ctx context.Context) error {
} }
func (n *Node) key(w http.ResponseWriter, r *http.Request) { func (n *Node) key(w http.ResponseWriter, r *http.Request) {
s := r.FormValue("s") s := r.PathValue("id")
id, err := chord.ParseID(s) id, err := chord.ParseID(s)
if err != nil { if err != nil {
writeError(w, http.StatusBadRequest, err.Error()) writeError(w, http.StatusBadRequest, err.Error())