studio/idle-survivors
2
0
Fork 0
Code Issues 14 Pull Requests 1 Packages Projects Releases Wiki Activity

feature-duder #9

Merged
zephyr merged 6 commits from feature-duder into main 2023-08-04 19:37:13 -04:00
Conversation 0 Commits 6 Files Changed 10 +7 -7
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 830444211f - Show all commits

4
Assets/Scripts/HeroClassSO.cs
View File

@ -3,6 +3,6 @@
[CreateAssetMenu(fileName = "HeroClass", menuName = "Hero Class")]
public class HeroClassSO : ScriptableObject
{
[SerializeField] private string Name;
[SerializeField] private string Help;
[SerializeField] private new string name;
[SerializeField] private string help;
}

10
Assets/Scripts/Heroism.cs
View File

@ -8,9 +8,9 @@
/// </summary>
public class Heroism : MonoBehaviour
zephyr marked this conversation as resolved Outdated
madxmike commented 2023-08-02 19:12:14 -04:00
Outdated
Review
Copy Link

Could we name this like HeroUnit or something

HeroUnit

EnemyUnit

Could we name this like `HeroUnit` or something `HeroUnit` `EnemyUnit`
{
[SerializeField] private string Name;
[SerializeField] private HeroClassSO Class;
[SerializeField] private long Level;
[SerializeField] private long XP;
[SerializeField] private HeroAttributesSO Attrs;
[SerializeField] private new string name;
[SerializeField] private HeroClassSO class_;
[SerializeField] private long level;
[SerializeField] private long xp;
zephyr marked this conversation as resolved Outdated
madxmike commented 2023-08-02 19:13:47 -04:00
Outdated
Review
Copy Link

dont change this now, but it would be nice in the future if we could encapsulate the concepts of level and xp in a single class. It might contain a XP -> level curve and then we can jsut .addXp and it will figure everything out. Would be useful if we have anywhere else that needs the same concepts

dont change this now, but it would be nice in the future if we could encapsulate the concepts of level and xp in a single class. It might contain a XP -> level curve and then we can jsut .addXp and it will figure everything out. Would be useful if we have anywhere else that needs the same concepts
[SerializeField] private HeroAttributesSO attrs;
}